Add more device skins #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy this pull request to the software-mansion Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
kmagiera
approved these changes
Apr 5, 2024
packages/vscode-extension/src/webview/views/DevicesNotFoundView.tsx
Outdated
Show resolved
Hide resolved
packages/vscode-extension/src/webview/views/DevicesNotFoundView.tsx
Outdated
Show resolved
Hide resolved
filip131311
force-pushed
the
@Filip131311/AddMoreDeviceSkins
branch
from
1563225
to
053b28c
Compare
filip131311
force-pushed
the
@Filip131311/AddMoreDeviceSkins
branch
from
14a9197
to
943b424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for: pixel 6a and iPhone SE (3rd generation), it also makes it possible to add new devices just by adding them to
vscode-extension/src/webview/utilities/consts.tsas a filed ofSupportedDevicesand providing relevant skin and mask into assets.Additionally this PR makes asset (device skin and maks) formats universal across android and ios, which because of bugs introduced by svg, fixes: #45.
Fixes: #47