-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more device skins #71
Conversation
Someone is attempting to deploy this pull request to the software-mansion Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but check inline comments
packages/vscode-extension/src/webview/views/DevicesNotFoundView.tsx
Outdated
Show resolved
Hide resolved
packages/vscode-extension/src/webview/views/DevicesNotFoundView.tsx
Outdated
Show resolved
Hide resolved
1563225
to
053b28c
Compare
14a9197
to
943b424
Compare
This PR adds support for: pixel 6a and iPhone SE (3rd generation), it also makes it possible to add new devices just by adding them to
vscode-extension/src/webview/utilities/consts.ts
as a filed ofSupportedDevices
and providing relevant skin and mask into assets.Additionally this PR makes asset (device skin and maks) formats universal across android and ios, which because of bugs introduced by svg, fixes: #45.
Fixes: #47